Fixes for Static diagram #1967
Merged
Fixes for Static diagram #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdodino
changed the title
PalumboN
approved these changes
Nov 18, 2020
| @@ -397,8 +396,8 @@ class StaticDiagramView extends AbstractDiagramView implements IDocumentListener | |||
| if (model instanceof ClassModel) { | |||
| val clazz = model.getComponent | |||
| if (clazz !== null) { | |||
| this.selection = new StructuredSelection(clazz) | |||
| val selectionChangedEvent = new SelectionChangedEvent(this, this.selection) | |||
| this.selection = new StructuredSelection(clazz) ?: selection | |||
There was a problem hiding this comment.
Este Elvis operator no está al revés?? O sea, un new nunca va a ser null. O me pegó de más la anestesia?
There was a problem hiding this comment.
la verdad, no tiene mucho sentido esa línea, sí recuerdo que hay un problema a veces en el constructor de SelectionChangedEvent o en StructuredSelection, ambos tienen un assertNotNull de selection. Pero lo que hice no podría arreglar nada. Probé de todo para ver si podía romperlo y nada:
class {}class __214 {}class A inherits Inexistente {}class A inherits {}
y no se rompe ni tira ningún warning...
volví a la versión anterior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
También solucioné un problema por el cual no se guardaba correctamente la información de tamaños y ubicaciones, ni el flag que los hacía recordar (siempre estaba activado).
Tuve que actualizar también el repo p2 de Xpect, se me rompió el IDE, voy a armar otro PR para rollbackear el cambio y de paso le meto una actualización a Babel NL porque está volviendo a tirar un warning.
Aproveché y metí el fix de #1948 (referencias cíclicas en la jerarquía rompen el diagrama estático) además del #1949, y también el #1940 para que no falle generar el archivo .wsdi si el workspace tiene espacios.