Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace username by user in Mongo Client connection options #347

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

juananpe
Copy link
Contributor

@juananpe juananpe commented Nov 25, 2020

According to the API docs for Mongo Client connection options:
https://api.mongodb.com/ruby/current/Mongo/Client.html#initialize-instance_method:~:text=characters-,.,%3A
the correct value for specifying the username of the connection string is user, not username.

Trying to log to mongo using "username" instead of "user" will yield the following error:

ERROR Logging failed: https://domain.com - there are no users authenticated (13) (on localhost, legacy retry, attempt 1)

It is also more clearly highlighted when using --debug option in whatweb:

W, [2020-11-25T22:02:15.304776 #262609] WARN -- : MONGODB | Unsupported client option 'username'. It will be ignored.

The attached patch allows to connect using authentication options and insert logs into mongo without problems:

./whatweb -p +./plugins-disabled/charset.rb --log-mongo-host localhost --log-mongo-database whatwebdb --log-mongo-username yyyyyyy --log-mongo-password xxxxxxx https://domain.com

@urbanadventurer
Copy link
Owner

Thanks @juananpe. It LGTM!

@urbanadventurer urbanadventurer merged commit ccbc9fa into urbanadventurer:master Nov 25, 2020
@juananpe juananpe deleted the mongouser branch January 1, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants