Wire up Flutter methods to proxy #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlepinski
reviewed
Mar 11, 2023
rlepinski
reviewed
Mar 11, 2023
oristanovic
reviewed
Apr 27, 2023
Apekka
changed the title
|
This looks good but I really need to do some testing on it to make sure its all good. Ill try to get to that by EOW. |
oristanovic
reviewed
Jul 5, 2023
|
We need to setup a listener in the autopilot that calls |
rlepinski
reviewed
Jul 10, 2023
rlepinski
reviewed
Jul 10, 2023
oristanovic
reviewed
Aug 3, 2023
lib/src/airship_push.dart
Outdated
| } | ||
|
|
||
| /// Sets the notification options. | ||
| Future<void> setForegroundPresentationOptions(List<ForegroundPresentationOption> options) async { |
There was a problem hiding this comment.
getting errors on this one
There was a problem hiding this comment.
They need to be converted to the expected string values and not just the enum. I would have an internal method convertOption that you switch on the type and return the string. You will need to do that for Features and NotificationOptions as well
rlepinski
reviewed
Aug 3, 2023
android/src/main/kotlin/com/airship/flutter/events/DeeplinkEvent.kt
Outdated
Show resolved
Hide resolved
rlepinski
reviewed
Aug 3, 2023
android/src/main/kotlin/com/airship/flutter/FlutterAutopilot.kt
Outdated
Show resolved
Hide resolved
rlepinski
reviewed
Aug 4, 2023
jyaganeh
reviewed
Aug 7, 2023
… into MOBILE-3532
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Proxy and wire up the flutter methods to it