Adds CONTRIBUTING #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| - Make minimal changes. PRs should be per-feature or per-issue | ||
| - Squash commits to a single commit before submitting your PR. | ||
| - Follow the existing coding style |
There was a problem hiding this comment.
just a note that in the future it would be great if this instead linked to a style guide
|
just a note about the workflow section and how I'm not +1 on codifying asking people to squash force push and do other dances in their PRs. Maybe just say that a messy commit history on a PR might require it to be squashed before the PR is accepted? Don't make the simple cases hard. |
| 4. Submit a PR from your fork's branch | ||
| 5. The maintainers will provide feedback, or accept your PR | ||
| 6. Rebase your branch off the current master, and squash commits | ||
| 7. Force-push to your fork's branch, and let the maintainer's know that it's |
There was a problem hiding this comment.
hmm.. isn't this going to wipe comments?
There was a problem hiding this comment.
does it? still, it's been removed.
|
Updated per @mintchaos's suggestions |
|
🌵 |
|
👶 |
|
merged via big green button |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
CONTRIBUTINGfile, which contains guidelines on contributing to this repository—reporting issues or submitting PRs, per issue #2.This PR is labeled WIP; please leave any feedback in comments.