getTotalInvites -> getTotalUsableInvites #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtobin
reviewed
Jun 4, 2019
| * @param {Number} point - The point whose invites to count | ||
| * @return {Promise<Number>} Total amount of invites | ||
| */ | ||
| module.exports.getTotalInvites = async function(contracts, point) { | ||
| const pool = await internal.getPool(contracts, as); |
There was a problem hiding this comment.
What the.. did this spurious-looking as pass my previous review? 🤔
jtobin
reviewed
Jun 4, 2019
| @@ -77,7 +87,7 @@ module.exports.getTotalInvites = async function(contracts, point) { | |||
| * Generate a list of planets for as to send as invites | |||
| * NOTE that the returned list isn't guaranteed to contain exactly amount items, | |||
There was a problem hiding this comment.
I forgot to mention this before as well, but technically this NOTE in the docstring should probably be better-formatted, since these things are designed to render nicely via JSDoc.
Which reminds me.. I should immediately tweak package.json to rebuild the docs before every publish. The API docs link in the README is an embarrassment.
There was a problem hiding this comment.
Ah, of course. Might just need to be Note: or w/e instead then? Thanks!
jtobin
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jtobin as mentioned, this is more useful if it checks for invites that you can actually use, rather than invites you have but can't actually get a planet for.