Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

u3: adds unconditional freelist migration as workaround #551

Merged
merged 1 commit into from
Nov 13, 2023
Merged

u3: adds unconditional freelist migration as workaround #551

merged 1 commit into from
Nov 13, 2023

Conversation

joemfb
Copy link
Member

@joemfb joemfb commented Nov 13, 2023

... early migration prerelease

In other words, my comment at #539 (comment) was wrong, the couple of ships that are affected cannot just meld because the loom-sane assertion runs too early.

@joemfb joemfb requested a review from a team as a code owner November 13, 2023 16:32
@pkova pkova merged commit 1b86849 into develop Nov 13, 2023
4 checks passed
@pkova pkova deleted the jb/free-list-hack branch November 13, 2023 16:35
@joemfb joemfb mentioned this pull request Nov 15, 2023
Merged
joemfb added a commit that referenced this pull request Nov 15, 2023
@joemfb
u3: removes free-list ream from v3 migration (#553)
95ac7bb 
The last minute migration change to #539 was just wrong. #551 is a
functional workaround, but the change to the v3 migration itself also
needs to be removed. We regret the error. (This can be fixed for real in
v4 migration.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkova pkova pkova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joemfb @pkova