Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stacktrace #674

Merged
merged 26 commits into from
Sep 16, 2024
Merged

Add stacktrace #674

merged 26 commits into from
Sep 16, 2024

Conversation

ripperi
Copy link
Contributor

@ripperi ripperi commented Jul 11, 2024

Related to #659

Adds backtrace printing to SIGSEGV signal handling. Tries to print file and line number with libbacktrace, falls back to using standard backtrace when debug info is unavailable.

Before:
Screenshot 2024-07-11 at 15 58 52

After (with dsyms):
Screenshot 2024-07-24 at 17 11 56

After (without dsyms):
Screenshot 2024-07-24 at 17 14 31

@ripperi ripperi force-pushed the ripa/stacktrace branch 2 times, most recently from 6d5e26c to 12a071e Compare July 24, 2024 14:28
@ripperi ripperi marked this pull request as ready for review July 24, 2024 14:33
@ripperi ripperi requested a review from a team as a code owner July 24, 2024 14:33
@ripperi ripperi force-pushed the ripa/stacktrace branch 3 times, most recently from 1cd1a99 to 31e561c Compare July 25, 2024 12:46
pkg/noun/manage.c Outdated Show resolved Hide resolved
@pkova pkova merged commit 3761ed0 into develop Sep 16, 2024
5 checks passed
@pkova pkova deleted the ripa/stacktrace branch September 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants