Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jet mismatches and crashes #703

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Fix jet mismatches and crashes #703

wants to merge 11 commits into from

Conversation

Quodss
Copy link
Contributor

@Quodss Quodss commented Aug 9, 2024

Resolves #700.

@joemfb
Copy link
Member

joemfb commented Aug 9, 2024

While you're at it, the +swp jet from #577 doesn't check the bloq size. I keep forgetting to fix that.

@Quodss
Copy link
Contributor Author

Quodss commented Aug 9, 2024

This PR will also fix comparison jet mismatches (lth, gth, lte, gte, min, max, mentioned in #699 ) when both inputs are equal cells

@Quodss Quodss marked this pull request as ready for review August 9, 2024 16:20
@Quodss Quodss requested a review from a team as a code owner August 9, 2024 16:20
@Quodss
Copy link
Contributor Author

Quodss commented Aug 11, 2024

A couple of other mismatches I found: ++dvr crashes the runtime unrecoverably, ++div exits on input [0 0 0] even though it should return 0. Proposal: make the core "type checks" more rigorous in u3w-prefixed jet functions, and return u3_none instead of exiting. I'll commit an example with ++add

@Quodss Quodss marked this pull request as draft August 12, 2024 10:57
@Quodss Quodss changed the title Sanitize jet inputs Fix jet mismatches and crashes Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

++cue jet crashes the runtime when the sample is a cell
2 participants