events: do not read garbage memory on empty control files #724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another one of the address sanitizer catches.
For whatever reason my directed messaging fakeship ended up in a situation with empty
control.bin
andmemory.bin
. When starting up this fakeship the address sanitizer blows up here:vere/pkg/noun/events.c
Lines 459 to 467 in f5799a9
len_w
is 0,malloc(0)
is implementation defined but does give a non-null pointer on macos, which means that on line 462 we are reading random garbage.