Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor App and Command to share logic #554

Closed
jszwedko opened this issue Oct 29, 2016 · 3 comments · Fixed by #1498
Closed

Refactor App and Command to share logic #554

jszwedko opened this issue Oct 29, 2016 · 3 comments · Fixed by #1498
Labels
area/v2 relates to / is being considered for v2 kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work status/confirmed confirmed to be valid, but work has yet to start
Milestone
Release 2.x

Comments

@jszwedko
Copy link
Contributor

jszwedko commented Oct 29, 2016 •
edited by meatballhat
Loading

Currently, there is a lot of duplication between the App and Command code paths. We should take the opportunity to clean this up for the next v2 release.

My thoughts are to embed Command in App and remove as many shared fields as is reasonable.
@jszwedko jszwedko added the kind/feature describes a code enhancement / feature request label Oct 29, 2016
@jszwedko jszwedko added this to the v2.0.0 milestone Oct 29, 2016
@jszwedko jszwedko mentioned this issue Oct 29, 2016
Closed
@coilysiren coilysiren removed this from the v2.0.0 milestone Aug 17, 2019
@coilysiren coilysiren added kind/feature describes a code enhancement / feature request status/confirmed confirmed to be valid, but work has yet to start and removed kind/feature describes a code enhancement / feature request labels Aug 17, 2019
@coilysiren coilysiren added area/v2 relates to / is being considered for v2 kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work and removed kind/feature describes a code enhancement / feature request labels Nov 27, 2019
@26tanishabanik
Copy link

26tanishabanik commented Sep 20, 2022 •
edited
Loading

@jszwedko , can I work on this issue?

@dearchap dearchap mentioned this issue Sep 20, 2022
Merged
@jszwedko
Copy link
Contributor Author

@26tanishabanik looks like @dearchap opened a PR for it, but yeah that seems fine by me! I defer to the current maintainers though. cc/ @urfave/cli

@icholy
Copy link
Contributor

icholy commented Sep 21, 2022

Embedding Command would be backwards incompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/v2 relates to / is being considered for v2 kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work status/confirmed confirmed to be valid, but work has yet to start
Projects
None yet
Milestone
Release 2.x
Development

Successfully merging a pull request may close this issue.

Cleanup redundant code in App/Command dearchap/cli
5 participants
@meatballhat @jszwedko @icholy @coilysiren @26tanishabanik