-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.21.0 regression when using pass-through commands #850
Comments
Pass through commands in general are (...) a bit difficult to support. The hotfix here is to invoke docker like this - myCLI myCommand --someArg someInput docker run --rm ubuntu bash
+ myCLI myCommand --someArg someInput -- docker run --rm ubuntu bash |
Tangentially, when you hit this bug it exits with code EDIT: this is probably a different bug report, though. |
Ah, the lack of an error response was because my specific CLI wasn't checking for an error from |
I'm going to start looking into this next week 📆 |
If anyone drops into this issue and definitely knows how to fix the problem, feel free to take this off my hands ^_^ You'll have to race me for the PR though 🏃♀ |
Beware before merging: there's an issue in urfave/cli 1.21.0: urfave/cli#850
Just ran a bisect, and it looks like this is the commit that caused the bug df562bf |
Which was merged in this PR #691 |
Beware before merging: there's an issue in urfave/cli 1.21.0: urfave/cli#850
In
1.20.0
this used to workIn
1.21.0
it's broken, with this error messageThe issue here is that the CLI is reading
--rm
as input tomyCommand
, rather than input todocker run
.The text was updated successfully, but these errors were encountered: