Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add word-wrap support based on terminal size #1044

Closed
wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jan 17, 2020

Highly experimental and still WIP.

Refers to #287

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #1044 into master will decrease coverage by 0.44%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
- Coverage    72.6%   72.15%   -0.45%     
==========================================
  Files          33       33              
  Lines        2482     2507      +25     
==========================================
+ Hits         1802     1809       +7     
- Misses        569      587      +18     
  Partials      111      111
Impacted Files Coverage Δ
help.go 78.1% <30.76%> (-7.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826e00c...f9559f8. Read the comment docs.

@saschagrunert
Copy link
Member Author

Hm, windows can be a problem here...

@asahasrabuddhe
Copy link
Member

@saschagrunert You can refer to this file for help with terminal size on Windows

@stale
Copy link

stale bot commented Apr 25, 2020

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

@stale stale bot added the status/stale stale due to the age of it's last update label Apr 25, 2020
@mostynb
Copy link
Contributor

mostynb commented Apr 28, 2020

I opened #1119 with this change + a speculative fix for windows.

@stale
Copy link

stale bot commented Apr 28, 2020

This issue or PR has been bumped and is no longer marked as stale! Feel free to bump it again in the future, if it's still relevant.

@stale stale bot removed the status/stale stale due to the age of it's last update label Apr 28, 2020
@saschagrunert
Copy link
Member Author

I opened #1119 with this change + a speculative fix for windows.

Ah thank you for taking this over, I'll close this one here.

@saschagrunert saschagrunert deleted the word-wrap-support branch April 28, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants