Add HideHelpCommand #1083
Merged
Add HideHelpCommand #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
+ Coverage 72.91% 73.18% +0.27%
==========================================
Files 33 33
Lines 2481 2480 -1
==========================================
+ Hits 1809 1815 +6
+ Misses 565 559 -6
+ Partials 107 106 -1
Continue to review full report at Codecov.
|
AkihiroSuda
force-pushed
the
hide-help-command
branch
2 times, most recently
from
2426f97
to
3e5678c
Compare
|
Any chance to get v2.2.0 released soon with this? |
rliebz
reviewed
Mar 5, 2020
AkihiroSuda
force-pushed
the
hide-help-command
branch
4 times, most recently
from
4604362
to
2129edf
Compare
While `HideHelp` hides both `help` command and `--help` flag, `HideHelpCommand` only hides `help` command and leave `--help` flag as-is. The behavior of `HideHelp` is untouched in this commit. Fix urfave#523 Replace urfave#636 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
hide-help-command
branch
from
2129edf
to
75e7c52
Compare
coilysiren
requested changes
Mar 6, 2020
Comment on lines
-333
to
-342
| // append help to commands | ||
| if len(a.Commands) > 0 { | ||
| if a.Command(helpCommand.Name) == nil && !a.HideHelp { | ||
| a.appendCommand(helpCommand) | ||
|
|
||
| if HelpFlag != nil { | ||
| a.appendFlag(HelpFlag) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
❓ (blocking question) this code is being removed because it was duplicated in Setup above, yeah?
There was a problem hiding this comment.
Yes, and because of the duplication, this code path was not executed and could not be covered with tests: #1083 (comment)
I can write up the release notes this weekend probs |
coilysiren
approved these changes
Mar 6, 2020
rliebz
approved these changes
Mar 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
While
HideHelphides bothhelpcommand and--helpflag,HideHelpCommandonly hides
helpcommand and leave--helpflag as-is.The behavior of
HideHelpis untouched in this commit.Which issue(s) this PR fixes:
Fixes #523
Replaces #636
Testing
go test -v -run TestHideHelpCommandRelease Notes