Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept multi-value input on slice flags #1241

Merged
merged 2 commits into from Apr 26, 2022

Conversation

vipally
Copy link
Contributor

@vipally vipally commented Feb 8, 2021

What type of PR is this?

  • bug

What this PR does / why we need it:

fix v2 bug: accept multi-value input on sclice flags.

Which issue(s) this PR fixes:

Fixes #1238

Testing

TestFlagValue has cover this case.

Release Notes

fix #1238: accept multi-value input on sclice flags

@vipally vipally requested a review from a team as a code owner Feb 8, 2021
@vipally vipally requested review from rliebz and coilysiren and removed request for a team Feb 8, 2021
@coilysiren coilysiren requested review from a team and removed request for rliebz and coilysiren Apr 23, 2021
@stale
Copy link

stale bot commented Jul 22, 2021

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

@stale stale bot added the status/stale stale due to the age of it's last update label Jul 22, 2021
@stale
Copy link

stale bot commented Aug 22, 2021

Closing this as it has become stale.

@stale stale bot closed this Aug 22, 2021
@wszychta
Copy link

wszychta commented Sep 13, 2021

@vipally @coilysiren Can you reopen this PR. It would be really useful in our case.

@coilysiren
Copy link
Member

coilysiren commented Sep 13, 2021

You can just bump it before it gets closed as stale????????

@coilysiren
Copy link
Member

coilysiren commented Sep 13, 2021

I'm going to reopen it but you have to actually do something about it if you don't want it to just get closed again

@coilysiren coilysiren reopened this Sep 13, 2021
@meatballhat meatballhat removed the status/stale stale due to the age of it's last update label Apr 21, 2022
@meatballhat meatballhat changed the title fix #1238: accept multi-value input on sclice flags Accept multi-value input on slice flags Apr 21, 2022
@meatballhat meatballhat added kind/bug describes or fixes a bug area/v2 relates to / is being considered for v2 labels Apr 21, 2022
@meatballhat meatballhat added this to the Release 2.5.0 milestone Apr 21, 2022
@meatballhat meatballhat changed the base branch from master to main Apr 21, 2022
@meatballhat meatballhat added this to the Release 2.6.0 milestone Apr 26, 2022
@meatballhat meatballhat merged commit 6538e95 into urfave:main Apr 26, 2022
4 checks passed
meatballhat added a commit that referenced this pull request Apr 26, 2022
Accept multi-value input on slice flags (#1241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2 relates to / is being considered for v2 kind/bug describes or fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept multi-value input on slice flags
4 participants