Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detect zsh via SHELL (#1218) #1350

Merged
merged 7 commits into from May 22, 2022
Merged

Auto-detect zsh via SHELL (#1218) #1350

merged 7 commits into from May 22, 2022

Conversation

meatballhat
Copy link
Member

@meatballhat meatballhat commented Apr 19, 2022

as re-opening #1218 is not currently possible given the source branch was deleted.

This PR is the result of:

curl -fsSL \
  https://patch-diff.githubusercontent.com/raw/urfave/cli/pull/1218.patch |
  git am

What type of PR is this?

(REQUIRED)

  • documentation
  • feature

What this PR does / why we need it:

See #1218

Which issue(s) this PR fixes:

See #1218

z0rc added 2 commits Apr 19, 2022
Completion file shouldn't be sourced. It should provide only completion
code (source of _command) for command. It's task for package manager or
user to put under $fpath.
There is no need to define custom shell var, when Zsh can be detected by
checking SHELL env var.
@meatballhat meatballhat requested a review from a team as a code owner Apr 19, 2022
@meatballhat meatballhat added kind/feature describes a code enhancement / feature request kind/documentation describes a documentation update area/v2 relates to / is being considered for v2 labels Apr 21, 2022
@meatballhat meatballhat added this to the Release 2.5.0 milestone Apr 21, 2022
@meatballhat meatballhat changed the base branch from master to main Apr 21, 2022
@meatballhat meatballhat dismissed a stale review via f3ef95f Apr 30, 2022
@meatballhat meatballhat changed the title Applying pr1218 Another approach for zsh completion (#1218) May 8, 2022
@meatballhat meatballhat changed the title Another approach for zsh completion (#1218) Auto-detect zsh via SHELL (#1218) May 22, 2022
@meatballhat meatballhat added kind/bug describes or fixes a bug kind/cleanup describes internal cleanup / maintaince and removed kind/feature describes a code enhancement / feature request labels May 22, 2022
@meatballhat meatballhat merged commit f528cf0 into main May 22, 2022
13 checks passed
@meatballhat meatballhat deleted the applying-pr1218 branch May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2 relates to / is being considered for v2 kind/bug describes or fixes a bug kind/cleanup describes internal cleanup / maintaince kind/documentation describes a documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants