Auto-detect zsh via SHELL (#1218)
#1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completion file shouldn't be sourced. It should provide only completion code (source of _command) for command. It's task for package manager or user to put under $fpath.
There is no need to define custom shell var, when Zsh can be detected by checking SHELL env var.
meatballhat
added
kind/feature
meatballhat
changed the title
meatballhat
changed the title
SHELL (#1218)
meatballhat
added
kind/bug
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as re-opening #1218 is not currently possible given the source branch was deleted.
This PR is the result of:
curl -fsSL \ https://patch-diff.githubusercontent.com/raw/urfave/cli/pull/1218.patch | git amWhat type of PR is this?
(REQUIRED)
What this PR does / why we need it:
See #1218
Which issue(s) this PR fixes:
See #1218