Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unshadow context package #1370

Merged
merged 1 commit into from Apr 24, 2022
Merged

Unshadow context package #1370

merged 1 commit into from Apr 24, 2022

Conversation

meatballhat
Copy link
Member

@meatballhat meatballhat commented Apr 24, 2022

What type of PR is this?

  • cleanup

What this PR does / why we need it:

The context package was being shadowed by local vars in a few places, which is not something that's currently being checked by a linter but it should be (in the future).

Which issue(s) this PR fixes:

N/A 馃槵

Special notes for your reviewer:

Also includes changes to consistently name *cli.Context vars and method receivers cCtx

and consistently name `*cli.Context` vars and method receivers `cCtx`
@meatballhat meatballhat added area/v2 relates to / is being considered for v2 kind/cleanup describes internal cleanup / maintaince labels Apr 24, 2022
@meatballhat meatballhat added this to the Release 2.4.x milestone Apr 24, 2022
@meatballhat meatballhat requested a review from a team as a code owner Apr 24, 2022
Copy link
Member

@asahasrabuddhe asahasrabuddhe left a comment

LGTM

@meatballhat meatballhat merged commit 801780f into main Apr 24, 2022
12 checks passed
@meatballhat meatballhat deleted the unshadow-context branch Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2 relates to / is being considered for v2 kind/cleanup describes internal cleanup / maintaince
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants