Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GPL2 dependency introduced in v2.7.0 #1405

Merged
merged 2 commits into from May 24, 2022

Conversation

AkihiroSuda
Copy link
Contributor

@AkihiroSuda AkihiroSuda commented May 24, 2022

What type of PR is this?

  • bug (In my understanding)

What this PR does / why we need it:

Replaces https://github.com/antzucaro/matchr (GPL2, introduced in v2.7.0) with https://github.com/xrash/smetrics (MIT License).

This is needed because downstream projects may use GPL2-incompatible licenses such as Apache License 2.0.

Which issue(s) this PR fixes:

Fixes #1404

Release Notes

Remove GPL2 dependency introduced in v2.7.0

@AkihiroSuda
Copy link
Contributor Author

AkihiroSuda commented May 24, 2022

CI failure seems irrelevant to the commit

go: golang.org/x/text@v0.3.7 requires
	golang.org/x/tools@v0.0.0-20180917221912-90fa682c2a6e: missing go.sum entry; to add it:
	go mod download golang.org/x/tools

https://github.com/urfave/cli/runs/6567968972?check_suite_focus=true

This commit replaces github.com/antzucaro/matchr (GPL2, introduced in v2.7.0)
with github.com/xrash/smetrics (MIT License).

Fixes issue 1404

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@meatballhat meatballhat merged commit 5ff4e2a into urfave:main May 24, 2022
13 checks passed
@meatballhat
Copy link
Member

meatballhat commented May 24, 2022

@AkihiroSuda Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants