Upgrade gopkg.in/yaml to v3 #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vulnerability: GHSA-hp87-p4gw-j4gq YAML v3 deserializes maps as map[string]interface{} so we handle this in MapImportSource now. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
mostynb
previously approved these changes
Jun 18, 2022
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
meatballhat
approved these changes
Jun 19, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Fixes vulnerability: GHSA-hp87-p4gw-j4gq
Which issue(s) this PR fixes:
Special notes for your reviewer:
yaml.v3 deserializes nested maps as
map[string]interface{}now. TOML still deserializes nested maps asmap[interface{}]interface{}. I considered updatingMapInputSourceto store amap[string]interface{}for itsvalueMapbut this would break the API ofNewMapInputSourceso I went with the approach you see here of handling bothmaptypes when looking up values.Testing
go build ./...go test ./...Release Notes