Argh core #1584
Closed
Argh core #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While working through this mess, I'm realizing that by moving away from stdlib |
dearchap
reviewed
Nov 15, 2022
internal/argh/token.go
Outdated
| IDENT // char group without flag prefix: 'some' 'words' | ||
| ARG_DELIMITER // rune(0) | ||
| ASSIGN // '=' | ||
| MULTI_VALUE_DELIMITER // ',' |
There was a problem hiding this comment.
this changes based on scanner config so say eg ','
meatballhat
force-pushed
the
argh-core
branch
from
7639320
to
26b286a
Compare
|
reopening shortly... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Swap out stdlib
flagwith the "argh" parserWhich issue(s) this PR fixes:
Closes #1583
Special notes for your reviewer:
This is highly experimental⚠️ I don't expect reviews at this time, which is why the PR is in draft 💖