Document slice flags as part of examples (v3) #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dearchap
reviewed
Jun 12, 2023
carhartl
changed the title
carhartl
force-pushed
the
document-slice-flags
branch
from
07f82dd
to
bc83065
Compare
carhartl
force-pushed
the
document-slice-flags
branch
from
bc83065
to
3cd32d8
Compare
dearchap
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example for how to use slice flags to
flags.mdin the v2 docs example directory, using aStringSliceFlagin the specific example. As instructed in #1005, which seems to indicate there's some demand for it.What type of PR is this?
What this PR does / why we need it:
Make the documentation more complete, so that users can get started without looking at source/tests/discussions, like me :)
Which issue(s) this PR fixes:
Fixes #1005
Release Notes