Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions (bump versions, improve naming a bit) #1895

Merged
merged 6 commits into from
May 1, 2024

Conversation

bartekpacia
Copy link
Member

What type of PR is this?

  • cleanup / CI

What this PR does / why we need it:

This PR updates all GitHub Actions we use to the latest versions. GitHub is phasing out Node.js 16 so actions have to be updated.

I also added the staticcheck linter, enabled. I've been using staticcheck for many years in my personal Go projects and it's a very useful tool. It also works great with golangci-lint.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Testing

This is a change related itself to testing.

Release Notes

None.

@bartekpacia bartekpacia requested a review from a team as a code owner April 30, 2024 19:31
@meatballhat
Copy link
Member

Sorry about the conflict, @bartekpacia!

@bartekpacia
Copy link
Member Author

@meatballhat no problem, resolved it :)

@bartekpacia
Copy link
Member Author

@meatballhat "diffcheck" is failing. I suppose the action here is to update godoc-current.txt, right? The changes in this PR are not breaking, it's just some receiver/args renaming)

@meatballhat
Copy link
Member

@meatballhat "diffcheck" is failing. I suppose the action here is to update godoc-current.txt, right? The changes in this PR are not breaking, it's just some receiver/args renaming)

Yep this is a bit clunky, but meant to guard against accidentally doing something not-semver. You can run make v3approve and commit + push the change if it looks good to you 👍🏼

@bartekpacia bartekpacia requested review from Juneezee, meatballhat and a team May 1, 2024 00:53
@bartekpacia bartekpacia merged commit 624c05a into urfave:main May 1, 2024
12 checks passed
@bartekpacia bartekpacia deleted the update_ci branch May 1, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants