-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable shell completion if double dash is included in arguments (v3) #1933
fix: disable shell completion if double dash is included in arguments (v3) #1933
Conversation
Arguments after double dash `--` are not flags but positional arguments. https://unix.stackexchange.com/a/11382
@suzuki-shunsuke Did you want this for v2 or v3 ? If you want it for v2 you need to base off v2-maint branch. Also I would suggest you add some test cases. |
Thank you for your review.
I think both v2 and v3 have this issue, so we should fix both v2 and v3.
Sure. I'll do it. |
v2 is in maint mode. No new features |
I think this is a bug fix rather than a new feature. I'm using v2 because v3 is still alpha, but if v3 is stable I will upgrade v2 to v3. |
a832345 I added tests. The base branch is ✅ I'll send another pull request for v2. |
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This pull request disables shell completion if double dash
--
is included in arguments.Arguments after double dash
--
are not flags but positional arguments.https://unix.stackexchange.com/a/11382
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #1932
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
Release Notes
(REQUIRED)