Fix can not set flag '-h' for custom #619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszwedko
requested changes
Apr 24, 2017
There was a problem hiding this comment.
Hi @chensongz
Thanks for starting this! In addition to my comments, do you mind adding tests for this behavior? I'd recommend testing:
--helponApps with no subcommands--helpon a subcommand--helpon anAppwith a subcommand (e.g.foo --help bar
| @@ -235,7 +235,7 @@ func checkHelp(c *Context) bool { | |||
| } | |||
|
|
|||
| func checkCommandHelp(c *Context, name string) bool { | |||
| if c.Bool("h") || c.Bool("help") { | |||
There was a problem hiding this comment.
I think it'd be more accurate to call the checkHelp method defined above.
|
It's been ~2 years since the changes were requested, so I'm comfortable closing this. Please feel free to re-open / create a new PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may want to set flag '-h' for other usage rather than "help".
But function
checkCommandHelpandcheckSubcommandHelpcheck every command for flag '-h' and '--help'. User-defined flag '-h' will always show help message.Only keep flag '--help' more reasonable.
Relate to #546