Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy appveyor changes from the V2 PR #898

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Copy appveyor changes from the V2 PR #898

merged 1 commit into from
Sep 19, 2019

Conversation

coilysiren
Copy link
Member

Copied from #892

@coilysiren coilysiren self-assigned this Sep 18, 2019
@coilysiren coilysiren mentioned this pull request Sep 18, 2019
Merged
@coilysiren coilysiren marked this pull request as ready for review September 18, 2019 07:24
@coilysiren coilysiren requested a review from a team as a code owner September 18, 2019 07:24
@codecov
Copy link

codecov bot commented Sep 18, 2019 •
edited
Loading

Codecov Report

Merging #898 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #898   +/-   ##
=======================================
  Coverage   71.45%   71.45%           
=======================================
  Files          30       30           
  Lines        2393     2393           
=======================================
  Hits         1710     1710           
  Misses        577      577           
  Partials      106      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c49a1...9072b3f. Read the comment docs.

saschagrunert
saschagrunert approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@coilysiren coilysiren merged commit 6b59274 into master Sep 19, 2019
@AudriusButkevicius AudriusButkevicius deleted the lynncyrin-patch-1 branch September 20, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@AudriusButkevicius AudriusButkevicius AudriusButkevicius approved these changes

@asahasrabuddhe asahasrabuddhe Awaiting requested review from asahasrabuddhe

Assignees

@coilysiren coilysiren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coilysiren @saschagrunert @AudriusButkevicius