Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide version if the version is not set by the user [v1] #954

Merged
merged 3 commits into from
Nov 28, 2019

Conversation

asahasrabuddhe
Copy link
Member

@asahasrabuddhe asahasrabuddhe commented Nov 28, 2019

Fixes #248
Fixes #524

Changes

  • Do not set default version
  • HideVersion is now true if the user does not define flag

@asahasrabuddhe asahasrabuddhe requested a review from a team as a code owner November 28, 2019 06:51
@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #954 into v1 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v1     #954      +/-   ##
==========================================
+ Coverage   71.64%   71.65%   +0.01%     
==========================================
  Files          30       30              
  Lines        2409     2410       +1     
==========================================
+ Hits         1726     1727       +1     
  Misses        577      577              
  Partials      106      106
Impacted Files Coverage Δ
app.go 84.51% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850de85...0e80c06. Read the comment docs.

@coilysiren coilysiren merged commit ebf9c3e into v1 Nov 28, 2019
@coilysiren coilysiren deleted the inconsistent-version-behaviour-v1 branch December 25, 2019 16:50
This was referenced Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants