Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pull request template #963

Merged
merged 6 commits into from Dec 1, 2019
Merged

Add a pull request template #963

merged 6 commits into from Dec 1, 2019

Conversation

@lynncyrin
Copy link
Member

lynncyrin commented Nov 29, 2019

This template has gone through a few iterations via my dayjob and personal projects

@lynncyrin lynncyrin requested a review from urfave/cli as a code owner Nov 29, 2019
@lynncyrin lynncyrin self-assigned this Nov 29, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #963 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #963   +/-   ##
=======================================
  Coverage   73.36%   73.36%           
=======================================
  Files          32       32           
  Lines        2440     2440           
=======================================
  Hits         1790     1790           
  Misses        540      540           
  Partials      110      110

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9db00f...0859d8f. Read the comment docs.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
lynncyrin and others added 4 commits Nov 29, 2019
Co-Authored-By: Sascha Grunert <mail@saschagrunert.de>
Copy link
Member

saschagrunert left a comment

LGTM 👍

@saschagrunert

This comment has been minimized.

Copy link
Member

saschagrunert commented Nov 29, 2019

We could think about using the kubernetes release notes generator for this project as well:
https://github.com/kubernetes/release/tree/master/cmd/release-notes

This would mean that we parse a release notes block like this:

- Changed something very important

in the PR body and process them.

@lynncyrin

This comment has been minimized.

Copy link
Member Author

lynncyrin commented Nov 29, 2019

We could think about using the kubernetes release notes generator for this project

👍👍👍 => #965

@lynncyrin lynncyrin merged commit 2dc008d into master Dec 1, 2019
6 checks passed
6 checks passed
codecov/patch Coverage not affected when comparing b9db00f...0859d8f
Details
codecov/project 73.36% remains the same compared to b9db00f
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.