Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pull request template #963

Merged
merged 6 commits into from
Dec 1, 2019
Merged

Add a pull request template #963

merged 6 commits into from
Dec 1, 2019

Conversation

coilysiren
Copy link
Member

@coilysiren coilysiren commented Nov 29, 2019

This template has gone through a few iterations via my dayjob and personal projects

@coilysiren coilysiren requested a review from a team as a code owner November 29, 2019 06:26
@coilysiren coilysiren self-assigned this Nov 29, 2019
@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #963 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #963   +/-   ##
=======================================
  Coverage   73.36%   73.36%           
=======================================
  Files          32       32           
  Lines        2440     2440           
=======================================
  Hits         1790     1790           
  Misses        540      540           
  Partials      110      110

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9db00f...0859d8f. Read the comment docs.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saschagrunert
Copy link
Member

We could think about using the kubernetes release notes generator for this project as well:
https://github.com/kubernetes/release/tree/master/cmd/release-notes

This would mean that we parse a release notes block like this:

- Changed something very important

in the PR body and process them.

@coilysiren
Copy link
Member Author

We could think about using the kubernetes release notes generator for this project

👍👍👍 => #965

@coilysiren coilysiren merged commit 2dc008d into master Dec 1, 2019
@coilysiren coilysiren deleted the pr-template branch December 25, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants