Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer #76

Merged
merged 15 commits into from
Jan 30, 2024
Merged

Footer #76

merged 15 commits into from
Jan 30, 2024

Conversation

sdmcraft
Copy link
Contributor

@sdmcraft sdmcraft commented Jan 29, 2024 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #3

Test URLs:

Pending Items:

  • Url links
  • Reuse global tokens
  • Social links

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 29, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 29, 2024 •
edited
Loading

Page Scores Audits Google
/blog/2023/11/supply-chain-issues-keeping-ceos-up-at-night PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

pahupe
pahupe reviewed Jan 29, 2024
View reviewed changes
blocks/footer/footer.css Outdated Show resolved Hide resolved
@sdmcraft sdmcraft marked this pull request as ready for review January 30, 2024 11:15
pahupe
pahupe approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@pahupe pahupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved.
Remaining issues will be added to a new footer ticker (iteration 2)

@sdmcraft sdmcraft merged commit 34b5932 into main Jan 30, 2024
2 checks passed
@sdmcraft sdmcraft deleted the footer branch January 30, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pahupe pahupe pahupe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blog: footer
2 participants
@sdmcraft @pahupe