Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gizmo is clipped by the UI area instead of the viewport #71

Closed
kvark opened this issue Jul 20, 2024 · 2 comments
Closed

Gizmo is clipped by the UI area instead of the viewport #71

kvark opened this issue Jul 20, 2024 · 2 comments

Comments

@kvark
Copy link
Contributor

kvark commented Jul 20, 2024

I'm migrating from egui-gizmo to transform-gizmo-egui. One of the surprises is that the gizmo is only drawing within the UI area:
transform-gizmo-clipping

This was not the case with "egui-gizmo".
In the viewport argument, I tried passing Rect::EVERYTHING or the actual window dimensions - doesn't help.
Finally, the gizmo is reacting to manipulation even if it's not visible. This makes the issue even more confusing to the user.
@kvark kvark mentioned this issue Jul 20, 2024
Merged
@kvark
Copy link
Contributor Author

kvark commented Jul 20, 2024 •
edited
Loading

For comparison, screenshot from egui-gizmo:
egui-gizmo

@Aeledfyr Aeledfyr mentioned this issue Jul 24, 2024
Open
urholaukkarinen added a commit that referenced this issue Oct 6, 2024
@urholaukkarinen
Fixed painter clipping in transform-gizmo-egui (#71)
06b31ce 
Painter's clip rect was always a sub-region of the UI's clip rect, so it was
not possible to draw outside the used UI. Now the whole gizmo viewport
is used as clip rect
urholaukkarinen added a commit that referenced this issue Oct 6, 2024
@urholaukkarinen
Merge pull request #82 from urholaukkarinen/71-fix-gizmo-clipping
7556fb3 
Fixed painter clipping in transform-gizmo-egui (#71)
@urholaukkarinen
Copy link
Owner

This should now be fixed in main and will be included in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @urholaukkarinen