Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typos in segment labels #10

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Conversation

bmcfee
Copy link
Contributor

@bmcfee bmcfee commented Oct 13, 2021

This PR fixes a handful of typos in the segment labels. This only really matters when the typos are inconsistent within the same annotation (which they often are).

@urinieto
Copy link
Owner

Great thanks! I wanted to edit the CHANGELOG and also 0156_lastnight.txt, which wasn't updated like its JAMS counterpart, but I don't seem to have permissions to commit to your branch, @bmcfee. Could you give me access? (Here are some instructions: https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork). Maybe you have already done that and I'm doing something wrong?

@bmcfee
Copy link
Contributor Author

bmcfee commented Oct 13, 2021

You should have access already? (The box was already checked)

@urinieto
Copy link
Owner

Weird, I'm getting this error:

Username for 'https://github.com': urinieto
Password for 'https://urinieto@github.com':
remote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead.
remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information.
fatal: Authentication failed for 'https://github.com/bmcfee/harmonixset.git/'```

I just checked, and I can push to my repos. Any ideas how I could fix this?

@eranegozy
Copy link
Collaborator

eranegozy commented Oct 13, 2021 via email

@urinieto
Copy link
Owner

Hey Eran, that worked, thanks! Just pushed the changes :)

@urinieto urinieto merged commit a3bda84 into urinieto:master Oct 13, 2021
@eranegozy
Copy link
Collaborator

eranegozy commented Oct 13, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants