Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cls for classmethod argument #137

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

carlthome
Copy link
Contributor

@carlthome carlthome commented Aug 17, 2023

Minor polish but self is reserved for the instance, so classmethods should not take in self but rather cls like in:

def select_features(cls, features_id, file_struct, annot_beats, framesync):

Stems out of seeing warnings from the Python extension in VS Code.

@urinieto urinieto merged commit 5581db7 into urinieto:main Aug 17, 2023
3 checks passed
@urinieto
Copy link
Owner

lgtm, thanks!

@carlthome carlthome deleted the rename-to-cls branch August 17, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants