Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log progress in collection mode #138

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

carlthome
Copy link
Contributor

Just a proposal (feel free to close!).

When running MSAF on SALAMI, it takes a while to process every feature, but there's no visible output during msaf.run.process in collection mode, so I thought my computer had frozen/crashed.

Would be nice to see some progress reporting with TQDM or similar. Turns out joblib already has support for printing some progress in the style of the following:

[Parallel(n_jobs=4)]: Using backend LokyBackend with 4 concurrent workers.
[Parallel(n_jobs=4)]: Done  33 tasks      | elapsed:    5.3s
[Parallel(n_jobs=4)]: Done 154 tasks      | elapsed:  1.1min

This PR enables that.

@urinieto
Copy link
Owner

Fantastic, thanks!

@urinieto urinieto merged commit 1f01745 into urinieto:main Sep 11, 2023
3 checks passed
@carlthome carlthome deleted the collection-mode-progress branch September 11, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants