Save sonified audio at 16-bit instead of 64-bit #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpvlordelo
reviewed
Sep 13, 2023
|
|
||
| # Convert audio to 16-bit signed integer | ||
| amplitude = np.iinfo(np.int16).max | ||
| data = (amplitude * out_audio).astype(np.int16) |
There was a problem hiding this comment.
why np.int16? Shouldn't it be np.float16?
There was a problem hiding this comment.
Because 32-bit audio cannot be stored at half-precision float without introducing quantization artifacts. Signed integer is necessary to retain audio fidelity.
|
Nice catch! Merging it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor thing but with
sonify_boundsset, the extra output audio file is really large (a 5 minute music track is around 60 MB even at only 22.05 kHz).Reason is
scipy.io.wavfile.writerespects the dtype of its input array, which is always doubles in NumPy when left unspecified.This PR adds the bit depth conversion from
scipy.io.wavfile.write's docstring (60 MB -> 15 MB).