This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Removed explicit module name for RequireJS (Issue 36) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urish
added a commit
that referenced
this pull request
Feb 17, 2015
Removed explicit module name for RequireJS (Issue 36)
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a response to [https://github.com//issues/36#issuecomment-69538169]. It's just a matter of removing the module name. People using RequireJS (and other AMD module loaders) should now be able to specify the module name themselves in their paths config e.g.
'angular-moment': '../bower_components/angular-moment/angular-moment.min','angularMoment': '../bower_components/angular-moment/angular-moment.min','am': '../bower_components/angular-moment/angular-moment.min',are all valid. Before, only the first was accepted.
I'm sorry I've taken so long to respond, and thank you for accepting my request for the change.