This repository has been archived by the owner on Oct 1, 2023. It is now read-only.
AMD compatible #11
Merged
AMD compatible #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for spin.js when packaged through RequireJS and thus not available in the global window.
|
Yeah this does work for me, but it seems like you need to check if "define" is defined, because it doesn't seem to go through the CI tests otherwise |
|
Merged + fixed unit tests |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some changes to get Spinner from an AMD injection instead of looking for it with angular's $window instance since spin.js doesn't put the class in the global window when RequireJS is used.