Add event marking #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! It seems like many parts of the code were reformatted, which makes the diff hard to follow. Can you run |
|
Yea, sorry man. I tried to clean everything up, but still having a little problem with prettier automatically changing some stuff. Hopefully it's a readable diff now! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple implementation of event markers that tie into the library.
All I've done is added an RxJS Subject to the MuseClient class, which can be imperatively trigged to send data with the new
injectMarkerfunction.It's helpful in my app, specifically as it introduces a similar API to the Emotiv SDK.
If needed, I can throw a recipe or example into the documentation to show how one might merge the events stream in with EEG using the
withLatestFromoperator.