Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do_restore_write_mbr without fixing_gpt flag #104

Merged
merged 3 commits into from
Nov 2, 2024
Merged

Conversation

cagnulein
Copy link
Contributor

as referenced here https://forums.urbackup.org/t/writing-gpt-backup-header-failed-error-on-restore/14451
I guess the code in the client_restore.cpp it was outdate about the fix mbr parameter.

@@ -808,7 +808,7 @@ msgid "tDo image backups over internet"
msgstr "Esegui backup immagine attraverso Internet"

msgid "tDo full file backups over internet"
msgstr "Esegui backup file atraverso Internet"
msgstr "Esegui backup file attraverso Internet"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here will be overwritten once the files are updated from Transifex

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah ok, so where should I do this change?

@uroni
Copy link
Owner

uroni commented Jun 23, 2024

The parameter is false in non-restore CD cases because there is no guarantee that sgdisk is available and the "fix" liberally relies on this.

Perhaps we can make the fix a parameter that is false by default?

@cagnulein
Copy link
Contributor Author

The parameter is false in non-restore CD cases because there is no guarantee that sgdisk is available and the "fix" liberally relies on this.

Perhaps we can make the fix a parameter that is false by default?

or maybe we can test the presence of sgdisk and set the parameter based on this and also maybe outputting something about this on the terminal?

@uroni uroni merged commit 8226431 into uroni:dev Nov 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants