EscapeHTML: Fix potentially vulnerable missing semicolon #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a missing semicolon in stringtools:EscapeHTML, specifically in the entity code for forward slash characters. This is theoretically exploitable in some way as the following payload: test/81;string will be escaped as: test⾁string Whenever this is unescaped, whether on the server, client, as a result of a server admin investigating log file, or in any other relevant circumstances, it will result in the following string: test⾁string This is a contrived example but there are many other code points in Unicode, meaning that it's difficult to fully eliminate the possibility of this being exploitable in some context, for example in a situation where a code point may affect the terminal being outputted to in some way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a missing semicolon in
stringtools:EscapeHTML, specifically in the entity code for forward slash characters.This is theoretically exploitable in some way, as the following payload:
test/81;stringwill be escaped as:
test⾁stringWhenever this is unescaped, whether on the server, client, as a result of a server admin investigating log file, or in any other relevant circumstances, it will result in the following string:
test⾁stringThis is a contrived example but there are many other code points in Unicode, meaning that it's difficult to fully eliminate the possibility of this being exploitable in some context, for example in a situation where a code point may affect the terminal being outputted to in some way.
Additionally, line ending mismatches in
getStreamFilehave been updated automatically by the GitHub edit or, so these are included in the patch.