Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error logging #2

Merged
merged 7 commits into from
Mar 15, 2019
Merged

Error logging #2

merged 7 commits into from
Mar 15, 2019

Conversation

urunimi
Copy link
Owner

@urunimi urunimi commented Mar 15, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 15, 2019

Codecov Report

Merging #2 into master will decrease coverage by 14.52%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #2       +/-   ##
===========================================
- Coverage   60.71%   46.19%   -14.53%     
===========================================
  Files           3        5        +2     
  Lines         140      210       +70     
===========================================
+ Hits           85       97       +12     
- Misses         39       95       +56     
- Partials       16       18        +2
Impacted Files Coverage Δ
plugin/echo/error_handler.go 61.53% <100%> (ø)
core/server.go 64.63% <36.36%> (-3.43%) ⬇️
plugin/echo/logrus.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cd7b5...ce3d296. Read the comment docs.

@urunimi urunimi merged commit e0cf619 into master Mar 15, 2019
@urunimi urunimi deleted the feature/logging branch March 15, 2019 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants