-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use deprecated positioning in the code and examples #869
Conversation
Deprecated, but still supported: * "fixed left" * "fixed right" * "fixed top" * "fixed bottom"
Literal["left", "center", "right"] | Align | tuple[Literal["relative", WHSettings.RELATIVE], int] | ||
Literal["left", "center", "right"] | ||
| Align | ||
| tuple[Literal["relative", WHSettings.RELATIVE, "fixed left", "fixed right"], int] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type annotate supported (not add to docs, just simplify work with existing code)
Pull Request Test Coverage Report for Build 8634468076Details
💛 - Coveralls |
examples/graph.py
Outdated
urwid.LEFT, | ||
urwid.RELATIVE_100, | ||
urwid.TOP, | ||
urwid.RELATIVE_100, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it we're breaking this into multiple lines there's room to use keyword args to make the parameters easier to understand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Stable doctests fail on python 3.11 linux.
UP: reproduced with the last python 3.11 docker image. |
sort = _call_modified(list.sort) # type: ignore[assignment] # magic like old __super__ | ||
if hasattr(list, "clear"): | ||
clear = _call_modified(list.clear) # type: ignore[assignment] # magic like old __super__ | ||
@_call_modified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
override explicit to allow __code__
for doctests
Deprecated, but still supported:
Checklist
master
orpython-dual-support
branchtox
successfully in local environment