Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate vcr fixtures #34

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Regenerate vcr fixtures #34

merged 5 commits into from
Nov 12, 2024

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Jan 23, 2024

Many of the tests were failing simply because the R functions were updated to work with changes to the API, but when the tests were run they were using mocked output from older versions of the API.
This PR regenerates the "cassettes" created by vcr since the API endpoint was updated (I simply deleted the entire tests/fixtures/ directory and ran devtools::test()). There are now 4 failing tests, which haven't been dealt with in this PR

@Aariq Aariq merged commit b3cd0b9 into usa-npn:master Nov 12, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant