Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout + addition Cascade Framework #34

Closed
wants to merge 2 commits into from
Closed

Update layout + addition Cascade Framework #34

wants to merge 2 commits into from

Conversation

jslegers
Copy link

Update layout + addition Cascade Framework

@afshinm
Copy link
Contributor

afshinm commented Mar 27, 2013

Wow! 16 files changed?! So, why?
Please only commit your changes, you should have no deletions in your pull request.

@jslegers
Copy link
Author

The "master" repo was still using an older layout.

I updated the "master" repo to the same layout and content as the "gh-pages" repo.

@afshinm
Copy link
Contributor

afshinm commented Mar 27, 2013

Ok, fine, but please let me fix this problem myself. You only need to change this files:

  • Readme on master branch.
  • compare.html in gh-pages branch.

That's all.

@jslegers
Copy link
Author

  • sigh *

That wasn't clear. I figured it made more sense to update the design in the "master" branch as well as the "compare" in the "gh-pages" branch, so they're both in synch.

Please check the repos on my account and verify for yourself if I made any changes you don't like.

@afshinm
Copy link
Contributor

afshinm commented Mar 27, 2013

@jslegers I know, I know. Sorry, that's my fault.

@jslegers
Copy link
Author

Would you be OK for you to commit the repos in their current state?

@jslegers
Copy link
Author

I just started from the current repo and tried everything all over.

I will close this request as it has been superseded by two new ones :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants