Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package local classes public #8

Closed
SKART1 opened this issue May 13, 2016 · 4 comments
Closed

Make package local classes public #8

SKART1 opened this issue May 13, 2016 · 4 comments

Comments

@SKART1
Copy link

SKART1 commented May 13, 2016

First of all thank you for brilliant wrapper above genius libusb library. But I faced some problems when trying to monitor usb devices - I need physical bus and port on which new device is connected. Something like:

@Override
public void usbDeviceAttached(UsbServicesEvent event) {
    DeviceId deviceId = ((AbstractDevice) event.getUsbDevice()).getId();
}

But AbstractDevice is package local! So are Hub and NonHub, so I can not call methods like getId() or getParentId() which are public!

SKART1 added a commit to SKART1/usb4java-javax that referenced this issue May 13, 2016
@siochs
Copy link

siochs commented Dec 15, 2017

Did not work for me. I had to declare the class DeviceId as public as well.

@SKART1
Copy link
Author

SKART1 commented Dec 15, 2017

You may put Some wrapper in same package from which actually call methods

@siochs
Copy link

siochs commented Dec 15, 2017

I was too lazy to add a wrapper ;) Just applied your changes including DeviceId publicity and now it works as expected.

@kayahr
Copy link
Member

kayahr commented Oct 21, 2018

I'm closing this as a duplicate of #10

@kayahr kayahr closed this as completed Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants