Wikidata Elastic Search - Frontend Implementation #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture for NodeSearchComponent
…tSearch" This reverts commit 4fb794b.
…ting nodes default for search
…d class, entity search of the existing nodes
Property store changes
binh-vu
reviewed
Jun 27, 2023
binh-vu
reviewed
Jun 27, 2023
binh-vu
reviewed
Jun 27, 2023
binh-vu
reviewed
Jul 2, 2023
| onSearch={onSearch} | ||
| filterOption={(inputValue, option) => { | ||
| if (option!.type != "class") { | ||
| let label = option?.filterlabel!; |
There was a problem hiding this comment.
rewrite line 146 to 158 to something like: return inputValue.split(" ").some(...);
There was a problem hiding this comment.
no question mark. also convert toLowerCase here.
There was a problem hiding this comment.
the replacement is still incorrect
binh-vu
reviewed
Jul 2, 2023
| onSearch={onSearch} | ||
| filterOption={(inputValue, option) => { | ||
| if (option!.type != "class") { | ||
| let label = option?.filterlabel!; |
There was a problem hiding this comment.
no question mark. also convert toLowerCase here.
| onSearch={onSearch} | ||
| filterOption={(inputValue, option) => { | ||
| if (option!.type != "class") { | ||
| let label = option?.filterlabel!; |
There was a problem hiding this comment.
the replacement is still incorrect
binh-vu
reviewed
Jul 2, 2023
| inputValue | ||
| .toLowerCase() | ||
| .split(" ") | ||
| .map((value) => { |
binh-vu
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated Wikidata Search Backend APIs to the frontend UI.
NodeSearchComponent adds source and target classes/entities to the semantic model knowledge graph.
OntSearchComponent adds class/entity/property to the semantic model knowledge graph.
The search implemented using OntSearchComponent completely uses the Wikidata API, unlike the previous implementation where there was ID based search from the local KG dump.
Property Search
Entity Search
Class Search
Source Node Search (Class)
Target Node Search (Class / Entity)