Refactor and clarify LaneType Enumerated Type #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-d-b
changed the title
This was
linked to
issues
Aug 6, 2021
chuehlien
approved these changes
Sep 21, 2021
Modified the entrance lane and entrance ramp descriptions to better clarify what they represent.
Modify the entrance lane description to say ingress to current roadway.
sknick-iastate
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
@j-d-b Looks good! I made a few changes to the entrance-lane and entrance-ramp descriptions. I did notice in a later commit you modified mainline in the exit-ramp to current roadway. I used mainline in the entrance-ramp description that you can modify if needed.
Do we also want to modify the description of type in the Lane Object table to match the change you made in the LaneType enumerations?
j-d-b
added
New Functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issues #149 and #5 by refactoring the values of the LaneType enumerated type for clarity and simplicity.
Specifically, the following changes were made to the LaneType enumerated type:
lanetogeneralright-turning-laneandleft-turning-laneright-exit-laneandleft-exit-laneexit-laneright-exit-rampandleft-exit-rampexit-rampright-entrance-rampandleft-exit-rampentrance-rampentrance-laneparkingmedianAlong with the following editorial changes: