Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML element ids need to be unique #102

Closed
jhfrench opened this issue Jan 21, 2015 · 3 comments · Fixed by #103
Closed

HTML element ids need to be unique #102

jhfrench opened this issue Jan 21, 2015 · 3 comments · Fixed by #103
Labels
bug

Comments

@jhfrench
Copy link
Contributor

There are two HTML elements in the playbook with an id of "plays":

$('[id="plays"]') //[<a class=​"anchor_offset" id=​"plays">​</a>​, <div id=​"plays" class=​"outer_container">​…​</div>​]

HTML element ids need to be unique.
@jhfrench jhfrench mentioned this issue Jan 21, 2015
Open
@jhfrench
Copy link
Contributor Author

Confirmed that "plays" is the only duplicated id (using $('[id]').each(function(){ console.log( $(this).prop('id') ); }); )

@cew821 cew821 added the bug label Jan 21, 2015
@cew821
Copy link
Contributor

cew821 commented Jan 21, 2015

Good catch, thanks. Will try to update this soon.

jhfrench added a commit to jhfrench/playbook that referenced this issue Jan 22, 2015
@jhfrench
Changed id, and references to it, for the first instance of `[id="pla…
69842f9 
…ys"]` (I decided that the first instance needed adjusting because `<div id="plays" class="outer_container">` is referenced numerous times by the CSS). Resolves usds#102
@jhfrench jhfrench mentioned this issue Jan 22, 2015
Merged
@jhfrench
Copy link
Contributor Author

Happy to help...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed id, and references to it, for the first instance of `[id="plays"... jhfrench/playbook
2 participants
@cew821 @jhfrench