Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make project carousels more like blog #923

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

TomNUSDS
Copy link
Contributor

  • Added carousel_show and carousel_image_alt_text to the markdown "liquid" header.
  • Add some comments to this header.
  • Fix some line wrapping issues.
  • TODO: the carousel_image_alt_text is just set to "Project photo" for now. We should customize it.

- Added `carousel_show` and `carousel_image_alt_text` to the markdown "liquid" header.
- Add some comments to this header.
- Fix some line wrapping issues.
- TODO: the `carousel_image_alt_text` is just set to  `"Project photo"` for now. We should customize it.
@TomNUSDS TomNUSDS self-assigned this Jan 12, 2024
@TomNUSDS TomNUSDS changed the base branch from master to staging January 12, 2024 22:05
Copy link

⚠️ Visual differences detected.
For details, click the green checkmark above.
If your PR makes intentional visual changes, update the base images by running the Visual regression testing Action.

@TomNUSDS TomNUSDS marked this pull request as ready for review January 12, 2024 22:09
@TomNUSDS TomNUSDS merged commit f24088b into staging Jan 12, 2024
2 checks passed
@TomNUSDS TomNUSDS deleted the tomn-usds/fix-project-carousel branch March 28, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant