Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BuildMode #298

Merged
merged 11 commits into from
Jul 22, 2021
Merged

Implement BuildMode #298

merged 11 commits into from
Jul 22, 2021

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Jul 8, 2021

Closes #284.

Kinda blocked until we have a release of ink! 3.0.0-rc4, since the ink_env/ink-debug feature is newer than the currently released 3.0.0-rc3. The tests are failing because they use the published ink! crates.

This PR adds a new CLI flag --release, which mirrors the behavior of cargo ‒ compiling the artifact in release mode is not done by default.

@cmichi cmichi requested a review from ascjones July 8, 2021 10:20
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good to go once ink! is released

src/cmd/build.rs Show resolved Hide resolved
src/cmd/build.rs Outdated Show resolved Hide resolved
@HCastano HCastano added the blocked This task is blocked until blockers are resolved. label Jul 14, 2021
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Now we just need rc4 to be pushed so the CI can pass

@cmichi cmichi mentioned this pull request Jul 19, 2021
@cmichi cmichi merged commit b5f241f into master Jul 22, 2021
@cmichi cmichi deleted the cmichi-implement-release-and-debug-mode branch July 22, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This task is blocked until blockers are resolved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable ink-debug feature for enabling debug messages
3 participants