Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ink_linting toolchain #2112

Merged
merged 9 commits into from
Apr 24, 2024
Merged

Update ink_linting toolchain #2112

merged 9 commits into from
Apr 24, 2024

Conversation

jubnzv
Copy link
Member

@jubnzv jubnzv commented Feb 13, 2024

Summary

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependant on the specific version of cargo-contract or pallet-contracts?

Description

Allows to build ink_linting with the recent Rust toolchain.

Checklist before requesting a review

  • (n/a) My code follows the style guidelines of this project
  • (n/a) I have added an entry to CHANGELOG.md
  • (n/a) I have commented my code, particularly in hard-to-understand areas
  • (n/a) I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@jubnzv jubnzv changed the title Update linting toolchain Update ink_linting toolchain Feb 13, 2024
@jubnzv jubnzv force-pushed the update-toolchain branch 2 times, most recently from 77f1e08 to 69bd94f Compare April 18, 2024 12:26
@jubnzv jubnzv marked this pull request as ready for review April 18, 2024 15:21
@jubnzv jubnzv marked this pull request as draft April 18, 2024 15:22
@jubnzv jubnzv marked this pull request as ready for review April 18, 2024 15:37
cmichi
cmichi approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jubnzv Thanks! Please also add an update to https://use.ink/linter/overview and the cargo-contract error message.

@cmichi cmichi merged commit ef91c60 into use-ink:master Apr 24, 2024
33 checks passed
jubnzv added a commit to jubnzv/ink-docs that referenced this pull request Apr 24, 2024
@jubnzv
linter: Update the toolchain version
4653e6c 
See: use-ink/ink#2112
@jubnzv jubnzv mentioned this pull request Apr 24, 2024
Merged
jubnzv added a commit to jubnzv/cargo-contract that referenced this pull request Apr 24, 2024
@jubnzv
chore: Update toolchain for ink_linting
c90be90 
See: use-ink/ink#2112
@jubnzv jubnzv mentioned this pull request Apr 24, 2024
Merged
4 tasks
cmichi pushed a commit to use-ink/cargo-contract that referenced this pull request Apr 25, 2024
@jubnzv
chore: Update toolchain for ink_linting (#1616)
a5dc570 
* chore: Update toolchain for `ink_linting`

See: use-ink/ink#2112

* chore: Update `ink_linting` version

* chore: Update toolchain
cmichi pushed a commit to use-ink/ink-docs that referenced this pull request Apr 26, 2024
@jubnzv
linter: Update the toolchain version (#339)
58fdbde 
See: use-ink/ink#2112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@cmichi cmichi cmichi approved these changes

@smiasojed smiasojed Awaiting requested review from smiasojed smiasojed is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jubnzv @ascjones @cmichi