Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ink! linker error protocol #685

Merged
merged 6 commits into from
Feb 10, 2021
Merged

Improve ink! linker error protocol #685

merged 6 commits into from
Feb 10, 2021

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Feb 10, 2021

Escalated from use-ink/cargo-contract#171.

@cmichi cmichi requested a review from Robbepop February 10, 2021 13:18
Robbepop
Robbepop reviewed Feb 10, 2021
View reviewed changes
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM all in all.
However, I'd put the trait_ident parameter before message or constructor ident. Rest looks fine.

ascjones
ascjones approved these changes Feb 10, 2021
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Robbepop
Robbepop approved these changes Feb 10, 2021
View reviewed changes
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmichi cmichi merged commit 8228bf0 into master Feb 10, 2021
@cmichi cmichi deleted the cmichi-update-linker-error-protocol branch February 10, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@Robbepop Robbepop Robbepop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmichi @ascjones @Robbepop