Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMD+W (Mac) closes the whole app, not just the current request tab #128

Closed
dcoomber opened this issue Mar 18, 2023 · 2 comments
Closed

CMD+W (Mac) closes the whole app, not just the current request tab #128

dcoomber opened this issue Mar 18, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted Community contribution is welcome

Comments

@dcoomber
Copy link
Member

In Postman, pressing CMD+W closes the current tab however in Bruno this key combination closes the whole application.
@dcoomber dcoomber changed the title CTRL+W / CMD+W closes the whole app, not just the current request tab CMD+W (Mac) closes the whole app, not just the current request tab Mar 18, 2023
@helloanoop helloanoop added good first issue Good for newcomers help wanted Community contribution is welcome labels Mar 19, 2023
@helloanoop
Copy link
Contributor

Makes sense @dcoomber
Cmd+W is kind of the used universally as a key to close the tab (incl chrome and vscode).

A good first issue for anyone in the community to pick up.

We would need to add a hotkey listener here
And call the closeTabs redux action with the current activeTabUid

dcoomber added a commit to dcoomber/bruno that referenced this issue Mar 19, 2023
@dcoomber
Proposed addition of CMD+W hotkey Re usebruno#128
8c29d13
@dcoomber dcoomber mentioned this issue Mar 19, 2023
Merged
dcoomber added a commit to dcoomber/bruno that referenced this issue Mar 21, 2023
@dcoomber
Applied code review feedback Re usebruno#128
5899ca4
helloanoop added a commit that referenced this issue Mar 21, 2023
@helloanoop
Merge pull request #134 from dcoomber/bugfix/128-close-tab-hotkey
b53a9ea 
Proposed addition of CMD+W hotkey Re #128
@helloanoop
Copy link
Contributor

This functionality is now available in v0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Community contribution is welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@helloanoop @dcoomber